refactor: replace ptr.To with new(expr)#26534
Open
sivchari wants to merge 1 commit intoargoproj:masterfrom
Open
refactor: replace ptr.To with new(expr)#26534sivchari wants to merge 1 commit intoargoproj:masterfrom
sivchari wants to merge 1 commit intoargoproj:masterfrom
Conversation
Use Go 1.26's new(expr) syntax instead of ptr.To helper function. This change only includes the ptr.To replacement and does not include removal of other helper functions. Note: AWS CodeCommit related files are intentionally excluded as they are being addressed in PR argoproj#26439. Signed-off-by: sivchari <shibuuuu5@gmail.com>
❗ Preview Environment deployment failed on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
14 tasks
|
|
||
| "github.com/argoproj/notifications-engine/pkg/api" | ||
| apierrors "k8s.io/apimachinery/pkg/api/errors" | ||
| "k8s.io/utils/ptr" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ptr.To()calls with Go 1.26'snew(expr)syntaxk8s.io/utils/ptrimportsNote
aws-sdk-go-v2#26439toPtr,createBoolPtr) will be handled in separate PRsSigned-off-by: sivchari shibuuuu5@gmail.com