chore(deps): remove unneeded Yarn resolutions#11641
chore(deps): remove unneeded Yarn resolutions#11641terrytangyuan merged 1 commit intoargoproj:masterfrom
Conversation
- removing these has no impact on resolution, as can be seen in the `yarn.lock` - any bumps in these deps will produce either the same minor or same major version (most are same minor version) -- i.e. no breaking changes - remove resolutions for `@types/react`, `autolinker`, `fast-json-patch`, `lodash`, and `prismjs` Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
terrytangyuan
left a comment
There was a problem hiding this comment.
I remember these resolutions were added to resolve security issues.
|
Per the first line of the PR, removing these has no impact on resolution. I imagine that those resolutions are either outdated or were used incorrectly to update a version in
|
terrytangyuan
left a comment
There was a problem hiding this comment.
We can merge and see if Snyk check passes
|
It did 😉 . |
Motivation
yarn.lockRelated to #11630, which removes unused deps; this removes unneeded
resolutionsModifications
remove resolutions for
@types/react,autolinker,fast-json-patch,lodash, andprismjsdid not touch
semverorreact-toastifysemverresolution currently forces all versions to the same as the resolution (including different majors, which can be seen in theyarn.lock)thereact-toastifyresolution was needed for fix: upgradeargo-uicomponents to latest #11585 and it is removed as part of build upgrades in build(ui): upgrade to Webpack v5 + upgrade loaders + plugins #11628Verification
Install succeeds, build passes.
Spot check on render.