Add mypy + pytest global config + small fixes.

demo_usage/cuboids_to_bboxes.py

@@ -348,7 +348,7 @@ def main(args: Any):
     logger.info(args)
 
     if args.log_ids is None:
-        logger.error(f"Please provide a comma seperated list of log ids")
-        raise ValueError(f"Please provide a comma seperated list of log ids")
+        logger.error("Please provide a comma seperated list of log ids")
+        raise ValueError("Please provide a comma seperated list of log ids")
 
     main(args)

demo_usage/visualize_30hz_benchmark_data_on_map.py

@@ -247,7 +247,7 @@ def render_bev_labels_mpl(
             city_to_egovehicle_se3: Transformation from egovehicle frame to city frame
             avm: ArgoverseMap instance
         """
-        if axis is not "city_axis":
+        if axis != "city_axis":
             # rendering instead in the egovehicle reference frame
             for da_idx, local_da in enumerate(local_das):
                 local_da = city_to_egovehicle_se3.inverse_transform_point_cloud(local_da)
@@ -262,7 +262,7 @@ def render_bev_labels_mpl(
         draw_lane_polygons(ax, local_lane_polygons)
         draw_lane_polygons(ax, local_das, color="tab:pink")
 
-        if axis is not "city_axis":
+        if axis != "city_axis":
             lidar_pts = rotate_polygon_about_pt(lidar_pts, city_to_egovehicle_se3.rotation, np.zeros((3,)))
             draw_point_cloud_bev(ax, lidar_pts)
 
@@ -283,7 +283,7 @@ def render_bev_labels_mpl(
                     bbox_ego_frame = rotate_polygon_about_pt(
                         bbox_ego_frame, city_to_egovehicle_se3.rotation, np.zeros((3,))
                     )
-                    if axis is "city_axis":
+                    if axis == "city_axis":
                         plot_bbox_2D(ax, bbox_city_fr, color)
                         if self.plot_lane_tangent_arrows:
                             bbox_center = np.mean(bbox_city_fr, axis=0)

pyproject.toml

@@ -1,3 +1,6 @@
+[tool.black]
+line-length = 120
+
 [tool.isort]
 known_first_party = "argoverse"
 known_third_party = "mayavi,pytest,colour,descartes,imageio,matplotlib,motmetrics,numpy,cv2,pandas,pillow,imageio,pyntcloud,scipy,shapely,sklearn"
@@ -6,5 +9,9 @@ line_length = 120
 multi_line_output = 3
 profile = "black"
 
-[tool.black]
-line-length = 120
+[tool.mypy]
+ignore_missing_imports = true
+strict = true
+
+[tool.pytest.ini_options]
+addopts = "--cov argoverse --cov-append --cov-branch --cov-report=term-missing"

tox.ini

@@ -12,9 +12,9 @@ deps =
     flake8-string-format
 
 commands =
-   pytest tests --cov argoverse --cov-append --cov-branch --cov-report=term-missing
-   flake8 --max-line-length 120 --ignore E203,E704,E711,E722,E741,W291,W293,W391,W503,F821,F401,F811,F841,P101,G004,G002,I201,I100,I101 --enable-extensions G argoverse
-   mypy --ignore-missing --strict argoverse
+   pytest tests
+   flake8 argoverse
+   mypy argoverse
 
 depends =
   py3{7,8}: clean