Merged
Conversation
benjaminrwilson
requested changes
Mar 27, 2023
tests/unit/evaluation/scene_flow/test_sf_submission_pipeline.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Benjamin Wilson <benjaminrwilson@users.noreply.github.com>
benjaminrwilson
requested changes
Mar 28, 2023
| """ | ||
| pred_file = predictions_dir / annotation_name | ||
| if not pred_file.exists(): | ||
| return None |
Collaborator
There was a problem hiding this comment.
I would either raise an error here or change the return type to Optional[pd.Dataframe].
| if path.exists(): | ||
| return pd.read_feather(zf.open(name)) | ||
| else: | ||
| return None |
Collaborator
There was a problem hiding this comment.
I would either raise an error here or change the return type to Optional[pd.Dataframe].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Added more tests to cover the validation of submission files fully. Also added a function for evaluating zipped predictions.
Testing
In order to ensure this PR works as intended, it is:
Compliance with Standards
As the author, I certify that this PR conforms to the following standards: