Skip to content

make angle a named parameter for matplotlib Rectangle constructor#235

Merged
benjaminrwilson merged 1 commit intoargoverse:mainfrom
viktortnk:patch-1
Dec 13, 2023
Merged

make angle a named parameter for matplotlib Rectangle constructor#235
benjaminrwilson merged 1 commit intoargoverse:mainfrom
viktortnk:patch-1

Conversation

@viktortnk
Copy link
Copy Markdown
Contributor

PR Summary

make angle a named parameter for matplotlib Rectangle constructor

https://matplotlib.org/stable/api/_as_gen/matplotlib.patches.Rectangle.html

According to the latest documentation matplotlib's Rectangle has only 3 positional arguments (not 4 as earlier).

As the name of parameters matches, the change should be compatible with earlier version of the library

Testing

In order to ensure this PR works as intended, it is:

  • unit tested.
  • other or not applicable (additional detail/rationale required)

Compliance with Standards

As the author, I certify that this PR conforms to the following standards:

  • Code changes conform to PEP8 and docstrings conform to the Google Python style guide.
  • A well-written summary explains what was done and why it was done.
  • The PR is adequately tested and the testing details and links to external results are included.

@benjaminrwilson
Copy link
Copy Markdown
Collaborator

Hi @viktortnk , thank you for the PR! Would you mind pulling in the latest changes from main so we can resolve the CI?

@viktortnk
Copy link
Copy Markdown
Contributor Author

Hi @benjaminrwilson
Sure, rebased.
I see all checks are green now

@benjaminrwilson benjaminrwilson merged commit 574a5e1 into argoverse:main Dec 13, 2023
@benjaminrwilson
Copy link
Copy Markdown
Collaborator

Great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants