Evaluation Code for Scenario Mining Challenge Release#295
Merged
benjaminrwilson merged 22 commits intoargoverse:mainfrom Mar 12, 2025
Merged
Evaluation Code for Scenario Mining Challenge Release#295benjaminrwilson merged 22 commits intoargoverse:mainfrom
benjaminrwilson merged 22 commits intoargoverse:mainfrom
Conversation
benjaminrwilson
requested changes
Mar 12, 2025
Collaborator
benjaminrwilson
left a comment
There was a problem hiding this comment.
Thanks, @CainanD! Looks good. Left a few comments. Also, was map_tutorial.ipynb meant to change?
Collaborator
|
Awesome, looks good. Thank you for making the changes, @CainanD. I still see a diff on the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Added scenario mining evaluation code in preparation for the new challenge release. Since the tracking is the primary evaluation metric, overall code changes are pretty minimal. Some additional logic was added to evaluate how the tracker performs at classifying time steps. This requires no additional dependencies. Included in this pull request are two small .pkl files that contain the predicted and ground truth track data to test the evaluation function.
Testing
This pull request includes a unit test and sample data files for the added evaluation script. The evaluation script works as intended.
In order to ensure this PR works as intended, it is:
Compliance with Standards
As the author, I certify that this PR conforms to the following standards:
Testing details showing complete coverage of av2/evaluation/scenario_mining/eval.py:
logs_35428725033.zip
Visualization of ground truth data:
https://github.com/user-attachments/assets/a0ef5497-7672-4365-ae95-e37e5597d975