Skip to content

Add UNKNOWN lane mark type to map schema#58

Merged
benjaminrwilson merged 2 commits intomainfrom
bugfix/add-lane-segment-mark-type
May 13, 2022
Merged

Add UNKNOWN lane mark type to map schema#58
benjaminrwilson merged 2 commits intomainfrom
bugfix/add-lane-segment-mark-type

Conversation

@wqi
Copy link
Copy Markdown
Collaborator

@wqi wqi commented May 12, 2022

PR Summary

This PR adds an UNKNOWN lane mark type to the map schema.

This change resolves an issue where attempting to load a static map containing such a lane mark type would result in a failure and error being raised.

Testing

Tested by loading a scenario containing an UNKNOWN lane mark type.

In order to ensure this PR works as intended, it is:

  • unit tested.
  • other or not applicable (additional detail/rationale required)

Compliance with Standards

As the author, I certify that this PR conforms to the following standards:

  • Code changes conform to PEP8 and docstrings conform to the Google Python style guide.
  • A well-written summary explains what was done and why it was done.
  • The PR is adequately tested and the testing details and links to external results are included.

Copy link
Copy Markdown
Collaborator

@benjaminrwilson benjaminrwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should add @unique to the other Enums in the changed file?

LGTM 👍

@benjaminrwilson benjaminrwilson merged commit 34c675e into main May 13, 2022
@benjaminrwilson benjaminrwilson deleted the bugfix/add-lane-segment-mark-type branch May 13, 2022 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants