Refactor(eos_designs): Inserting the dhcp accept default route when mgmt_ip is dhcp

[MaheshGSLAB]

Change Summary

Related Issue(s)

Fixes #6534

Component(s) name

arista.avd.eos_designs

Proposed changes

If mgmt_ip is dhcp then add the dhcp accept default route and avoid to add static route for mgmt_gateway

How to test

Run molecule

Checklist

User Checklist

• N/A

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[github-actions]

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-6627
# Activate the virtual environment
source test-avd-pr-6627/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/avd.git@issue-6534#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
python -m ansible.cli.galaxy collection install git+https://github.com/MaheshGSLAB/avd.git#/ansible_collections/arista/avd/,issue-6534 --force
cd test-avd-pr-6627
# Run your playbook using `python -m ansible.cli.playbook path/to/playbook.yml ...`

You can also test this PR using AVD playground:

• Rebase your branch to makes sure it is up-to-date and has latest lab topologies for example inventories
• Authenticate on labs.arista.com. Use your email! Not login.
• Start the playground
• In the lab selector UI pick "I want to use a specific AVD fork"
• Enter following parameters:

GitHub org: MaheshGSLAB
Repository name: avd
Branch: issue-6534

• Select an example inventory to test the PR
• Once the AVD Playground setup will be finished, type make start and test anything once the lab is up

[laxmikantchintakindi]

LGTM. Added minor comment.

[Shivani-gslab]

LGTM

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.21%. Comparing base (0862161) to head (be3109a).
⚠️ Report is 2 commits behind head on devel.

Additional details and impacted files

@@            Coverage Diff             @@
##            devel    #6627      +/-   ##
==========================================
+ Coverage   87.20%   87.21%   +0.01%     
==========================================
  Files         350      350              
  Lines       19152    19176      +24     
  Branches     3585     3593       +8     
==========================================
+ Hits        16701    16725      +24     
  Misses       1887     1887              
  Partials      564      564              

Files with missing lines	Coverage Δ
python-avd/pyavd/_eos_designs/shared_utils/mlag.py	94.44% <100.00%> (+0.08%)	⬆️
...vd/_eos_designs/structured_config/base/__init__.py	97.14% <100.00%> (+0.03%)	⬆️
..._eos_designs/structured_config/base/snmp_server.py	100.00% <100.00%> (ø)
...designs/structured_config/metadata/digital_twin.py	89.28% <100.00%> (+1.28%)	⬆️
...yavd/_eos_designs/structured_config/overlay/cvx.py	100.00% <100.00%> (ø)
...esigns/structured_config/overlay/management_cvx.py	100.00% <100.00%> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[carl-baillargeon]

LGTM!

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Comments solved.

[tkrenn-hc]

@MaheshGSLAB Just wanted to give you a heads up that this may create a breaking change in SNMP engine_id if you are already using

snmp_settings.compute_local_engineid_source: rfc3411_type5
snmp_settings.local_engineid_ip: use_default_mgmt_method_interface

in AVD 6.1.0 with DHCP for management. Would it be worth allowing a loopback or router_id to be used as a standard option for snmp_settings.local_engineid_ip?