[ATfE] Fail with an error message when -frwpi is used. (#428)#438
Closed
MarkMurrayARM wants to merge 0 commit intoarm:release/arm-software/21.xfrom
Closed
[ATfE] Fail with an error message when -frwpi is used. (#428)#438MarkMurrayARM wants to merge 0 commit intoarm:release/arm-software/21.xfrom
MarkMurrayARM wants to merge 0 commit intoarm:release/arm-software/21.xfrom
Conversation
Contributor
|
As far as I can see, llvm/llvm-project#149132 isn't on this release branch, so clang won't be including |
fd2f805 to
2ed83df
Compare
2ed83df to
8b4370a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ATfE doesn't currently provide any library variants built for RWPI. And if you link RWPI with non-RWPI code, nothing good will happen – they have incompatible ABIs. So we ought to give an error message rather than silently choose an incompatible library.
Using llvm/llvm-project#149132 which allowed multilib selection to be aware of the relocation model at all, this commit does the simplest possible thing: adds a catch-all error message that will trigger on any use of
-frwpi, and report that there's no suitable library variant.(Another possibility would have been to add
-fno-rwpito the validity criteria for each existing library, but that seemed less likely to give a good error message. It would allow RWPI variants to be present for some cases but not all, but at the moment, we don't need that.)Since the error message works the same everywhere, I've just added one test.
(cherry picked from commit 43cc67f)