fix: variable casing#91
Merged
arnetheduck merged 2 commits intoarnetheduck:masterfrom Jan 15, 2025
AuHau:fix/variable-casing
Merged
fix: variable casing#91arnetheduck merged 2 commits intoarnetheduck:masterfrom AuHau:fix/variable-casing
arnetheduck merged 2 commits intoarnetheduck:masterfrom
AuHau:fix/variable-casing
Conversation
Owner
|
nph compiles fine with 2.0.14 but what you've likely done is adding the For this higher level of case correctness to be maintained, this PR should add the stylecheck flag to nph's own CI as well, probably via |
Contributor
Author
Oh pardon my ignorance then 😅
Will do, thanks for the pointer! |
Contributor
Author
|
@arnetheduck done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nph would not compile under Nim 2.0.14 because casing of the variable names does not match declaration.