-
Notifications
You must be signed in to change notification settings - Fork 6
Open
Description
Hi.
Having read the very same article and after some thinking I thought of implementing the very same library but luckily googled first. Congrats on making it before me :)
But I would suggest making the names shorter as the Go as a language tries to make everything concise and even the variable names are encouraged to be single letter in certain cases.
I observe the following problems (from my humble point of view) with the current naming (nursery.RunConcurrently()).
- The
nurseryterm usually refers to raising children, but since we run our goroutines to their very death, it's probably not perfect. - The
RunConcurrentlyis already two words and just from the sound of it it's not clear, if the goroutines would be still running from after that - The "nursery run parallel" is not really a phrase.
My ideas on how to name it would be:
sync.Do(), thoughsyncis taken so might cause problems for some people and still fails point (3)await.Run()- that seems to work around problem (2) due to package name choicescoped.Run()- feels a little better than previous one, tough the workaround for (2) is not there already.- ...
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels