Skip to content

updating extract table prop#1005

Merged
Soeb-aryn merged 4 commits into
mainfrom
SH_extract_table_prop
Nov 7, 2024
Merged

updating extract table prop#1005
Soeb-aryn merged 4 commits into
mainfrom
SH_extract_table_prop

Conversation

@Soeb-aryn
Copy link
Copy Markdown
Contributor

No description provided.

@Soeb-aryn Soeb-aryn changed the title Sh extract table prop updating extract table prop Nov 6, 2024
@Soeb-aryn Soeb-aryn requested a review from HenryL27 November 6, 2024 22:35
Copy link
Copy Markdown
Collaborator

@HenryL27 HenryL27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall suggested prompt:
"""
You are given a table represented as CSV (comma-separated values). Determine whether key-value pairs can be extracted from the table. A key cell may correspond to multiple value cells. Return True if the table represents key-value pairs, and return False if it does not. Do not output any text other than True or False.
"""

Comment thread lib/sycamore/sycamore/llms/prompts/default_prompts.py Outdated
Comment thread lib/sycamore/sycamore/llms/prompts/default_prompts.py Outdated
Comment thread lib/sycamore/sycamore/llms/prompts/default_prompts.py Outdated
Comment thread lib/sycamore/sycamore/llms/prompts/default_prompts.py Outdated
Comment thread lib/sycamore/sycamore/llms/prompts/default_prompts.py Outdated
Comment thread lib/sycamore/sycamore/transforms/extract_table_properties.py
Copy link
Copy Markdown
Collaborator

@HenryL27 HenryL27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple anal grammar nits but lgtm

Comment thread lib/sycamore/sycamore/llms/prompts/default_prompts.py Outdated
Comment thread lib/sycamore/sycamore/llms/prompts/default_prompts.py Outdated
Comment thread lib/sycamore/sycamore/llms/prompts/default_prompts.py Outdated
@Soeb-aryn Soeb-aryn merged commit c0fc538 into main Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants