Favor doc_reconstruct when reconstruct_document is also mentioned#1210
Merged
Conversation
Contributor
There was a problem hiding this comment.
PR Overview
This PR modifies the OpenSearch reader initialization to favor the use of a document reconstructor over a boolean flag when both are provided.
- Added a condition to disable the reconstruct_document flag when a doc_reconstructor is set.
- Updated logging to inform users which configuration is being used.
Reviewed Changes
| File | Description |
|---|---|
| lib/sycamore/sycamore/connectors/opensearch/opensearch_reader.py | Added a conditional block that logs and disables the reconstruct_document flag when a doc_reconstructor is provided to favor the latter. |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
lib/sycamore/sycamore/connectors/opensearch/opensearch_reader.py:284
- There is a naming inconsistency between 'reconstruct_document' and 'doc_reconstructor'. Consider aligning the variable names (e.g., using 'doc_reconstruct') to clearly reflect that the document reconstructor is favored when both are set.
if query_params.reconstruct_document and query_params.doc_reconstructor is not None:
HenryL27
approved these changes
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.