Allow override of OpenSearch user/password in run_plan().#1256
Merged
Conversation
baitsguy
approved these changes
Apr 17, 2025
| def test_modified_context(): | ||
| params = {"paramKeyA": {"llm": 1}, "paramKeyB": {"llm": ["llm1", "llm2"]}, "default": {"llm": "openai"}} | ||
| c0 = Context(params=params) | ||
| c1 = modified_context(c0, "default", llm="dromedary") |
Contributor
There was a problem hiding this comment.
can you add a test to update a non-default context as well since access paths are different
| """Run the given logical query plan and return a tuple of the query ID and result.""" | ||
| assert self.context is not None, "Running a plan requires a configured Context" | ||
| if os_client_args: | ||
| my_ctx = modified_context(self.context, "default", os_client_args=os_client_args) |
Contributor
There was a problem hiding this comment.
fine for now, I wonder if we'll need to scope this to the "opensearch" namespace
Collaborator
Author
There was a problem hiding this comment.
It seemed a bit murky as to how a piece of code like this could know what downstream namespace was relevant, or even how namespaces would be used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.