Standardize materialize filenames a little#1283
Merged
Merged
Conversation
Signed-off-by: Henry Lindeman <hmlindeman@yahoo.com>
Signed-off-by: Henry Lindeman <hmlindeman@yahoo.com>
Signed-off-by: Henry Lindeman <hmlindeman@yahoo.com>
Signed-off-by: Henry Lindeman <hmlindeman@yahoo.com>
Signed-off-by: Henry Lindeman <hmlindeman@yahoo.com>
Signed-off-by: Henry Lindeman <hmlindeman@yahoo.com>
Signed-off-by: Henry Lindeman <hmlindeman@yahoo.com>
Signed-off-by: Henry Lindeman <hmlindeman@yahoo.com>
dhruvkaliraman7
approved these changes
May 3, 2025
Contributor
dhruvkaliraman7
left a comment
dhruvkaliraman7
left a comment
There was a problem hiding this comment.
Few nits, nice work!
| assert len(self.metadata["lineage_links"]["from_ids"]) > 0 | ||
|
|
||
| self.data["doc_id"] = mkdocid() | ||
| if "doc_id" not in self.data: |
Contributor
There was a problem hiding this comment.
Why do we need this?
Collaborator
Author
There was a problem hiding this comment.
o/w metadata documents get a new docid every time they're materialized (as materialize call the constructor) which I'm pretty sure is the incorrect behavior
|
|
||
| # Create a function that fails for specific documents | ||
| def failing_map(doc): | ||
| # logger.info(doc) |
| @@ -674,9 +688,9 @@ def test_materialize_read_reliability_retries_successful(self): | |||
| docs = make_docs(10) | |||
Contributor
There was a problem hiding this comment.
At the end of this test can we assert that we have 11 docs? The make_docs should give you 10 Documents and 1 MetadataDocument
Collaborator
Author
There was a problem hiding this comment.
depending on how docs get batched through noop I can't guarantee that there will be 11 but I can assert that there are at least one
| return d | ||
|
|
||
|
|
||
| logger = logging.getLogger(__name__) |
| ret = [] | ||
| count = 0 | ||
| for fi in self._fshelper.list_files(self._root): | ||
| # logger.info(fi) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent: add ability to materialize from a list of doc_ids
Resulting changes: