Upgrade setuptools.#1309
Merged
Merged
Conversation
karanataryn
approved these changes
May 20, 2025
| grpcio = "^1.60.0" | ||
| cbor2 = "^5.6.0" | ||
| sycamore-ai = "^0.1.13" | ||
| protobuf = "4.25.3" # See poetry-lock/pyproject.toml |
Contributor
There was a problem hiding this comment.
Are we sure we don't need this anymore? Would rather delete it.
Contributor
Author
There was a problem hiding this comment.
We don't use remote-processors anymore. poetry-lock was just broken in this project with this. I can delete it, but I confess I don't know whether there will be issues.
Contributor
There was a problem hiding this comment.
Ok got it. I'd suggest adding a comment stating that at least.
Contributor
Author
There was a problem hiding this comment.
I removed it. Don't think it matters much either way since I don't think anyone knows or is using this code.
| overrides = "^7.7.0" | ||
| structlog = "^24.2.0" | ||
| setuptools = ">70.0.0" | ||
| setuptools = ">78.1.1" |
Contributor
There was a problem hiding this comment.
Nit: > or >= ? Looks like the latter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/aryn-ai/sycamore/security/dependabot/375