Handle case where query is a compound query#1319
Merged
Merged
Conversation
eric-anderson
approved these changes
May 29, 2025
| expected = {"p3"} | ||
| assert expected == {d.doc_id for d in retrieved_docs} | ||
|
|
||
| query_with_filter = { |
Collaborator
There was a problem hiding this comment.
keep the old test, it still seems valid. Make a new test test_compound_query.
| "must": [actual_query], | ||
| "filter": [{"terms": filter}], | ||
|
|
||
| if is_compound_query(query): |
Collaborator
There was a problem hiding this comment.
Per IM discussion, don't do this, instead always wrap -- add a test for the wrapping of a compound query.
https://docs.opensearch.org/docs/latest/query-dsl/compound/index/
says you can have multiple levels "Compound queries serve as wrappers for multiple leaf or compound clauses either to combine their results or to modify their behavior."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.