Skip to content

Add HeaderAugmenterMerger#946

Merged
dhruvkaliraman7 merged 7 commits into
mainfrom
dhruv/add-augment-merger
Oct 21, 2024
Merged

Add HeaderAugmenterMerger#946
dhruvkaliraman7 merged 7 commits into
mainfrom
dhruv/add-augment-merger

Conversation

@dhruvkaliraman7
Copy link
Copy Markdown
Contributor

No description provided.

@dhruvkaliraman7 dhruvkaliraman7 changed the title Dhruv/add augment merger Add HeaderAugmenterMerger Oct 18, 2024
Comment thread lib/sycamore/sycamore/transforms/merge_elements.py Outdated
Comment thread lib/sycamore/sycamore/transforms/merge_elements.py Outdated
Comment thread lib/sycamore/sycamore/transforms/merge_elements.py Outdated
Comment thread lib/sycamore/sycamore/transforms/merge_elements.py Outdated
@MarkLindblad
Copy link
Copy Markdown
Contributor

Can you add a unit test for this?

Comment thread lib/sycamore/sycamore/transforms/merge_elements.py Outdated
Comment thread lib/sycamore/sycamore/transforms/merge_elements.py Outdated
Comment thread lib/sycamore/sycamore/transforms/merge_elements.py
Comment thread lib/sycamore/sycamore/transforms/merge_elements.py
Comment thread lib/sycamore/sycamore/transforms/merge_elements.py Outdated
Comment thread lib/sycamore/sycamore/transforms/merge_elements.py Outdated
Comment thread lib/sycamore/sycamore/transforms/merge_elements.py Outdated
Comment thread lib/sycamore/sycamore/transforms/merge_elements.py
Comment thread lib/sycamore/sycamore/transforms/merge_elements.py Outdated
Comment thread lib/sycamore/sycamore/transforms/merge_elements.py Outdated
Comment thread lib/sycamore/sycamore/transforms/merge_elements.py
Comment thread lib/sycamore/sycamore/transforms/split_elements.py
Comment thread lib/sycamore/sycamore/transforms/merge_elements.py Outdated
Comment thread lib/sycamore/sycamore/transforms/merge_elements.py
Comment thread lib/sycamore/sycamore/transforms/merge_elements.py Outdated
Comment thread lib/sycamore/sycamore/transforms/merge_elements.py Outdated
Comment thread lib/sycamore/sycamore/transforms/merge_elements.py
Comment thread lib/sycamore/sycamore/transforms/merge_elements.py
Comment thread lib/sycamore/sycamore/tests/unit/transforms/test_merge_elements.py Outdated
Copy link
Copy Markdown
Contributor

@MarkLindblad MarkLindblad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@dhruvkaliraman7 dhruvkaliraman7 merged commit 6a7fcb2 into main Oct 21, 2024
@dhruvkaliraman7 dhruvkaliraman7 deleted the dhruv/add-augment-merger branch October 21, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants