ci: fail-fast Go format check and add copilot-setup-steps timeout#478
Merged
ci: fail-fast Go format check and add copilot-setup-steps timeout#478
Conversation
Move gofmt check before go mod download/build/test in build-go job so formatting failures are caught immediately (~1-2 min savings on failure). Add timeout-minutes: 10 to copilot-setup-steps job to prevent runaway runner consumption on network issues or hung dependency installs. Implements suggestion from #463. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements two small CI workflow optimizations suggested in issue #463: reordering Go format check for fail-fast behavior and adding a safety timeout to the copilot-setup-steps job.
Changes:
- Move
gofmtformat check step to run immediately afteractions/setup-go(before dependency download, build, and test) in thebuild-gojob, so formatting failures fail quickly without wasting time on the rest of the pipeline. - Add
timeout-minutes: 10to thecopilot-setup-stepsjob to prevent runaway runner consumption from hung network or dependency installs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Reorders steps in build-go: Format check moved before go mod download, go build, and go test |
.github/workflows/copilot-setup-steps.yml |
Adds timeout-minutes: 10 to the copilot-setup-steps job |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move gofmt check before go mod download/build/test in build-go job so
formatting failures are caught immediately (~1-2 min savings on failure).
Add timeout-minutes: 10 to copilot-setup-steps job to prevent runaway
runner consumption on network issues or hung dependency installs.
Implements suggestion from #463.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com
Closes #463
Closes #465