Improve performance and error handling in web components

[askpt]

Enhance database query efficiency by applying Take() at the SQL layer and caching prompt files to reduce disk I/O. Remove unnecessary debug logs and implement error handling in the FeatureFlagsModal to provide clearer feedback to users when API calls fail. Add unit tests for the prompt loader functionality to ensure reliability.

closes #505
closes #504
closes #503
closes #502
closes #499
closes #498
closes #497
closes #496
closes #495

[Copilot]

Pull request overview

This PR improves runtime efficiency and user feedback across the sample app by pushing winner limits down to the database query layer, caching chatbot prompt parsing, cleaning up frontend debug logging, and introducing clearer error handling for feature-flag fetch failures. It also adds initial Python unit tests for prompt loading/rendering and small CI/pipeline hygiene updates.

Changes:

• Optimize winners retrieval by applying Take() in EF Core SQL queries and using AsNoTracking().
• Cache .prompt.yml prompt loading in the ChatService and move deferred imports to module scope.
• Improve web UX by removing debug logs and showing a fetch error state in FeatureFlagsModal; add Python unit tests for prompt_loader.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/Garage.ApiService/Services/WinnersService.cs	Pushes winner limiting into DB query and limits JSON results earlier.
src/Garage.ChatService/prompt_loader.py	Adds lru_cache to avoid repeated disk I/O and YAML parsing for prompts.
src/Garage.ChatService/main.py	Moves time/grpc imports to module level for clarity and minor perf.
src/Garage.ChatService/test_prompt_loader.py	Adds pytest unit tests for prompt loading/rendering/model params.
src/Garage.ChatService/requirements-test.txt	Introduces isolated test dependency requirements for pytest.
src/Garage.FeatureFlags/main_test.go	Fixes response body close error handling in test helper.
src/Garage.Web/src/components/Home.tsx	Removes debug console.log statements.
src/Garage.Web/src/components/CarCard.tsx	Removes debug console.log statement.
src/Garage.Web/src/components/FeatureFlagsModal.tsx	Adds an error UI state when feature-flag fetch fails.
.github/workflows/ci.yml	Improves pip cache keying by pinning cache dependency path.
global.json	Changes .NET SDK roll-forward behavior (now latestMajor).

Comments suppressed due to low confidence (2)

src/Garage.ChatService/prompt_loader.py:28

• load_prompt is now cached, but it returns a mutable dict that callers can mutate. With lru_cache, any accidental mutation will affect all future callers (shared cached object) and can cause hard-to-debug cross-request behavior. Consider returning an immutable structure or a defensive copy (e.g., deep copy) to prevent cache poisoning via mutation.

@lru_cache(maxsize=10)
def load_prompt(prompt_name: str, prompts_dir: str = "prompts") -> dict[str, Any]:
    """Load a .prompt.yml file and return parsed content.

    Results are cached in-memory so repeated calls with the same arguments
    avoid redundant disk I/O and YAML parsing.
    
    Args:
        prompt_name: Name of the prompt (without extension)
        prompts_dir: Directory containing prompt files
        
    Returns:
        Parsed YAML content as a dictionary
        
    Raises:
        FileNotFoundError: If the prompt file doesn't exist
    """
    prompt_path = Path(prompts_dir) / f"{prompt_name}.prompt.yml"
    with open(prompt_path, 'r', encoding='utf-8') as f:
        return yaml.safe_load(f)

.github/workflows/ci.yml:146

• The new test_prompt_loader.py suite isn’t exercised in CI right now: build-python only installs requirements.txt and runs py_compile. If these tests are intended to prevent regressions, add a pytest step (installing requirements-test.txt) and consider including requirements-test.txt in cache-dependency-path so cache keys change when test deps change.

          cache-dependency-path: src/Garage.ChatService/requirements.txt
      - name: Install dependencies
        run: |
          python -m pip install --upgrade pip
          pip install -r requirements.txt
      - name: Check syntax
        run: python -m py_compile main.py prompt_loader.py

---

You can also share your feedback on Copilot code review. Take the survey.

[Copilot]

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

.github/workflows/ci.yml:146

• This PR adds pytest-based unit tests under src/Garage.ChatService/, but the build-python job still only runs py_compile and never executes the tests. Consider adding a CI step to install the test requirements and run pytest so these tests actually protect against regressions (and, if you do, include requirements-test.txt in the pip cache key inputs).

          python-version: '3.14'
          allow-prereleases: true
          cache: 'pip'
          cache-dependency-path: src/Garage.ChatService/requirements.txt
      - name: Install dependencies
        run: |
          python -m pip install --upgrade pip
          pip install -r requirements.txt
      - name: Check syntax
        run: python -m py_compile main.py prompt_loader.py

---

You can also share your feedback on Copilot code review. Take the survey.