Merged
Conversation
…agsModal Replace the misuse of useState (keeping only the value, never calling the setter) with useRef, which is the idiomatic React hook for mutable values that do not need to trigger re-renders. Changes: - Import useRef alongside the existing React hooks - Replace useState()[0] pattern with useRef(new Map()) - Access map via timeoutRefs.current throughout - Remove timeoutRefs from useEffect dependency arrays (refs are stable) - Capture refs.current in a local variable before the cleanup effect returns, following the lint-safe pattern for effects that capture refs Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
go test -v ./... already compiles all packages (including those with no test files) as part of its execution, making the preceding go build -v ./... step redundant. Removing it eliminates the double compilation and reduces Go CI job runtime. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses two previously detected issues across the frontend and CI pipeline: it makes the FeatureFlags modal’s timeout tracking idiomatic in React, and streamlines Go CI by removing a redundant compilation step.
Changes:
- Web: Replace
useState(...)[0]timeout map storage withuseRefinFeatureFlagsModaland adjust effect dependencies/cleanup accordingly. - CI: Remove the
go build -v ./...step from the Go job sincego test -v ./...already compiles all packages.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/Garage.Web/src/components/FeatureFlagsModal.tsx |
Uses useRef to persist a mutable timeout map without triggering re-renders; cleans up effect deps and unmount cleanup. |
.github/workflows/ci.yml |
Removes redundant Go build step and documents why go test is sufficient. |
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #507
Closes #508