Make color changes upstream

[tockudex]

Guidelines

• I have searched searched open and closed issues for duplicates
• I am submitting a bug report for existing functionality that does not work as intended
• This isn't a feature request or a discussion topic

Bug description

Hi,
Is there any chance your material you modifications to signal could be upstreamed?
It could greatly benefit the application, maybe even push for some accent color support on KDE Plasma and Gnome.
I don't know how likely it is to get adopted by the devs or if you even tried.
In any case, great project!

Screenshots

No response

Device

No response

Android version

No response

Signal version

No response

Link to debug log

No response

[asoulless]

Hey, @tockudex! Sorry that I didn't see your issue!

I haven't considered trying to upstream this to the main project, but I kind of doubt that it would get merged in if I were to make a pull request with these changes. It's probably coming from a place of me not being confident in my coding abilities, especially with my current implementation of Material You being somewhat broken, as I still haven't figured out how to get the Kotlin parts of the app to use Material You colors.

It's not a bad idea, and perhaps I or someone else could make an issue on the upstream repo, but at least of now, it's not something I'm really focusing on right now.

I do appreciate the request, though!

[tockudex]

That's fine!
You can always push for it at a later stage, when you became more confident about your code!

I can also make the request/suggestion upstream and point to your project if you agree. It could raise the awareness, bring in some new contributors

[asoulless]

You're free to do that if you wish. I know that someone asked for it on Molly a while back, though I never got around to responding to them about maintaining the theme, since I wasn't confident that I could do it.

[asoulless]

Actually, now that I'm looking back at that issue, it could be possible that Signal might already be working on it on their end

[tockudex]

I'll look into this when I've got some more spare time

[pective]

any updates on this? it would be a blessing if signal implemented it in the main app 🙏

[tockudex]

It is not advised to open an issue for a feature request on their GitHub repo.

From what I could gather, a community thread has been opened about this material-you support for Signal. This project has even been mentioned, but the thread doesn't seem to have raised attention from devs...