make rendering of substeps as separate page optional#174
make rendering of substeps as separate page optional#174rbedemann wants to merge 2 commits intoastefanutti:masterfrom rbedemann:master
Conversation
astefanutti
left a comment
astefanutti
left a comment
There was a problem hiding this comment.
This would basically covers #24 so it'd be great to have it implemented as well for the Reveal plugin at least.
| totalSlides : await plugin.slideCount(options.enableSubsteps), | ||
| }; | ||
|
|
||
| if(options.enableSubsteps===false){ |
There was a problem hiding this comment.
This is specific to Impress so that should better be added to the configure method of the Impress plugin.
The options object can be passed to the Impress plugin constructor.
| default : 0, | ||
| help : 'Duration in milliseconds between the page has loaded and starting to export slides', | ||
| }, | ||
| enableSubsteps: { |
There was a problem hiding this comment.
This would basically cover #24. I wonder what could be the best terminology across all the HTML presentation frameworks. Reveal calls it fragments, other refer to incremental display of slide content...
| } | ||
|
|
||
| slideCount() { | ||
| slideCount(enableSubsteps) { |
There was a problem hiding this comment.
I think it'd be preferable to have the options object passed to the Impress plugin constructor and remove the extra argument.
| printBackground : true, | ||
| pageRanges : '1', | ||
| displayHeaderFooter : false, | ||
| scale: 1.5 |
There was a problem hiding this comment.
I think it's related to #107 and specific to Impress. I would suggest we add an option and change the default value for Impress instead of hard-coding the value for all presentation frameworks.
astefanutti
force-pushed
the
master
branch
4 times, most recently
from
a570d12 to
46b23e5
Compare
2 participants
Sometimes you want to have all the substeps immediately visible in pdf files and not as separate pages for every substep. With these changes, there will be a
--substeps=falseoption to disable generation of pages for each substep.