Conversation
…ly nothing will survive the final implementation
…nstructor is tentative. Will be changed to something nicer.
Collaborator
Author
Closed
lutzhamel
reviewed
Feb 22, 2022
Collaborator
lutzhamel
left a comment
There was a problem hiding this comment.
Hi Oliver, quick question, does the introduction of the ExpectationError exception change the behavior of the -e flag?
Collaborator
Author
|
Nope, the -e flag works the same. You can think of |
lutzhamel
approved these changes
Feb 22, 2022
Collaborator
lutzhamel
left a comment
There was a problem hiding this comment.
Nice work! This will help me a lot when I teach 301 using Asteroid!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR implements a REPL for asteroid. The REPL is now the default run option for asteroid. (i.e. running
asteroidruns the REPL).The REPL has two basic functions:
This PR also adds a new error class,
ExpectationError. Technically a subset of allSyntaxError's, this type of exception is raised when the parser/lexer expected a token but did not find it.If possible, try to break this PR! I'm wondering if this scheme is robust enough.