Conversation
added 2 commits
March 26, 2022 14:58
olwmc
approved these changes
Mar 27, 2022
Collaborator
olwmc
left a comment
There was a problem hiding this comment.
This is incredible!! Great work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
This PR introduces patterns that are truly values which has all kinds of ramifications. One of them is the fact that we can pattern match on patterns and we can access sub-structures of patterns computationally,
Another implication is that patterns can always match themselves,
Finally, we can now formally show that patterns constructed with the pattern keyword and patterns constructed as objects are two different things,
The fact that these two patterns are not equivalent is very satisfying since they were constructed very differently: The pattern constructed with the pattern keyword is a purely structural pattern whereas the pattern constructed as an object was constructed using an object constructor -- in this case just the default constructor but we could have also used a customized constructor.