Conversation
olwmc
approved these changes
Oct 29, 2022
Collaborator
olwmc
left a comment
olwmc
left a comment
There was a problem hiding this comment.
Looks great! Nice work as always.
TimColaneri
approved these changes
Oct 30, 2022
Collaborator
TimColaneri
left a comment
TimColaneri
left a comment
There was a problem hiding this comment.
Looks good to me. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exceptions now behave properly by popping the runtime stack as they look for a handler. In order to have good error reporting we maintain an error_trace that points to the place in the program where the exception was thrown