Skip to content

Adding token collection to lex.py for REPL project#306

Merged
ethan-j-carlson merged 5 commits intodev-2.0.2from
repl
Mar 11, 2024
Merged

Adding token collection to lex.py for REPL project#306
ethan-j-carlson merged 5 commits intodev-2.0.2from
repl

Conversation

@ethan-j-carlson
Copy link
Copy Markdown
Contributor

This pull request is for the features added for my proposed 2/5/2024 and 2/26/2024 milestones, adding a function to collect all identifiers defined by either the user (variables, functions, etc.) or the language (keywords, built-ins, etc.), with another function to filter the identifiers based on a prefix.

These additions were added into lex.py as the functions get_identifiers and get_identifiers_by_prefix

Additionally, a file was added to .gitignore (asteroid/repl_test.py), that I have been using to test out these features

Comment thread .gitignore
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test cases need to go into the testsuite folder

Copy link
Copy Markdown
Collaborator

@lutzhamel lutzhamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@lutzhamel
Copy link
Copy Markdown
Collaborator

feel free to merge this

@ethan-j-carlson ethan-j-carlson merged commit 670019f into dev-2.0.2 Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants