Skip to content

[src] Upgrade Lightning to 1.x#371

Merged
mpariente merged 12 commits intomasterfrom
lightning1x
Dec 12, 2020
Merged

[src] Upgrade Lightning to 1.x#371
mpariente merged 12 commits intomasterfrom
lightning1x

Conversation

@mpariente
Copy link
Collaborator

Fixed

  • configure_optimizers needed to return a dictionary when the scheduler is ReduceLROnPlateau.

Changed

  • Use self.log in training and validation step (very practical)

Didn't find out yet

  • Logging hyperparams, tried several way.

Before merging

Need to test that the recipes still work.

@mpariente
Copy link
Collaborator Author

@JorisCos could you have a look if things are working how you expect them to on your end please?

@JorisCos
Copy link
Collaborator

JorisCos commented Dec 1, 2020

Not very important but is it me or there is something wrong here ?
Capture d’écran du 2020-12-01 14-50-52 Why is it written 'loEpoch' before val_losss ?

@JorisCos
Copy link
Collaborator

JorisCos commented Dec 1, 2020

Otherwise, everything looks fine to me !

@mpariente
Copy link
Collaborator Author

Not very important but is it me or there is something wrong here ?
Capture d’écran du 2020-12-01 14-50-52 Why is it written 'loEpoch' before val_losss ?

Yes, it does look weird.

Actually, the distributed_backend has been renamed accelerator (see here), maybe it's more automatized when we use that. I'll have a look.

@mpariente mpariente merged commit 37b8a86 into master Dec 12, 2020
@mpariente mpariente deleted the lightning1x branch December 12, 2020 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants