Drop librosa dependency and refactor requirements files #378

[jonashaag]

• Use julius for resampling
• Add optional librosa support for file_separate
• Refactor file_separate

TODO: Fix librosa usage in one notebook

[jonashaag]

Shall we add soundfile to the Torch test dependencies?

[mpariente]

This is prettier this way, cool!

[mpariente]

Shall we add soundfile to the Torch test dependencies?

Yes. For the torch.hub tests as well then.

[mpariente]

There is a mismatch between the requirements filenames (test vs dev).

[jonashaag]

OK, will fix that notebook. Are you ok with the requirements changes? (No actual changes to requirements except librosa, only moved them to files)

[mpariente]

I like the split, but I wonder if we don't make a requirements folder to put all the files in, what's your take on that?

[jonashaag]

yeah why not, we could also move the docs requirements there:

requirements/
  requirements.txt
  requirements_dev.txt
  requirements_test.txt
  requirements_docs.txt

Or?

requirements/
  default.txt
  dev.txt
  test.txt
  docs.txt

[mpariente]

Yes.
Option 2 for me

[mpariente]

LGTM
Only librosa to install at the beginning of the notebook right?

[jonashaag]

LGTM
Only librosa to install at the beginning of the notebook right?

I think so

[jonashaag]

When I change the notebook the diff is huge (almost the entire notebook JSON), is this expected? I'll upload the version I wanted to commit

[jonashaag]

Stupid GitHub does not allow ipynb

00_GettingStarted.ipynb.zip

[mpariente]

Yes, this is expected..
That's why nbdev uses something like nbdiff.
Did you rerun the notebook?

[mpariente]

librosa should be installed at the begining of the notebook right?

[jonashaag]

I didn't rerun it.

I deliberately moved the librosa import to the visualisation part and used soundfile for loading the example waveform to show that you don't need librosa.

[mpariente]

But then it's not installed right for the visualization right?
The notebook should be ran again IMO

[jonashaag]

Ran it again and did some changes to the text regarding Zenodo. https://colab.research.google.com/drive/1_2Dbd0lXcSbaTjzUKtdmFtfV_Y_2QPYX?usp=sharing

[mpariente]

Cannot open the colab

[mpariente]

Let's fix the tests and merge this.

[jonashaag]

Oh no I deleted that Google account recently 🤦‍♂️ Gotta redo the changes

[jonashaag]

I think this should be good now

[mpariente]

The diffs from notebooks are really weird. We might want to use nbdev for reviewing in the future

[jonashaag]

Yeah it’s a mess. There are also some stripping tools to remove stuff like “Out [42]” that may frequently change