Add stft_n_filters to BaseDCUNet#406
Conversation
change default parameter to match DCUNet paper
|
There is a problem with CI (1.7.0 build) that might be related to the stride (changed input shape), could someone have a look? The other STOI problem on the nightly build should be fixed now. |
|
We can have a closer look to what's wrong with DCCRNet @jonashaag |
|
Could you explain the fix please? What was wrong? |
|
Sure, I added |
|
At first, I was confused by the jit tests on DCCRNet that kept failing, but it was because I didn't change this line |
|
Before, because |
|
Makes complete sense, thanks for the explanation! |
mpariente
left a comment
There was a problem hiding this comment.
After the required edits on the tests, we'll merge that, thanks again
pass everything as kwargs
|
Thanks again ! |
This PR adds
stft_n_filtersas mentionned in #404.It also fixes the defaults parameter of DCUNet to match its paper as mentionned in #400