Add note about System Lightning hooks#428
Merged
Conversation
mpariente
reviewed
Feb 3, 2021
Comment on lines
+17
to
+19
| class MySystem(System): | ||
| def on_train_batch_start(self, batch, batch_idx, dataloader_idx): | ||
| return self.model.on_train_batch_start(batch, batch_idx, dataloader_idx) |
Collaborator
There was a problem hiding this comment.
Should this be a code block?
Collaborator
Author
There was a problem hiding this comment.
It is, :: at the end of a line is special ReST syntax for "insert : and expect a code block"
Collaborator
|
Let's fix the linter and merge, thanks. |
Collaborator
Author
|
Did you install /lint now or not? :D |
Collaborator
|
I couldn't make it work.. |
Collaborator
|
/rebase |
github-actions
bot
force-pushed
the
system-hooks-docs
branch
from
ca7033e to
1e3d936
Compare
Collaborator
|
/lint |
Collaborator
|
The action did run, successfully, but it tells there is nothing to lint.. I'd have to dig into that a bit more.
|
Collaborator
Author
|
It’s 2021 and we’ll soon all be driven around in our autonomous cars but auto linting and formatting GitHub PRs is an unsolved problem |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #411