Recipe for X-UMX (using MUSDB18)#490
Merged
mpariente merged 7 commits intoasteroid-team:masterfrom May 6, 2021
Merged
Conversation
r-sawata
changed the title
Collaborator
mpariente
reviewed
May 6, 2021
mpariente
approved these changes
May 6, 2021
Collaborator
mpariente
left a comment
mpariente
left a comment
There was a problem hiding this comment.
I made few changes, and asked a few small others.
When those are addressed, we can merge it.
…dels/xumx_test.py"
mpariente
reviewed
May 6, 2021
mpariente
reviewed
May 6, 2021
mpariente
reviewed
May 6, 2021
Collaborator
mpariente
left a comment
mpariente
left a comment
There was a problem hiding this comment.
Can you confirm about the requirements installation that it's ok for you please?
We can merge afterwards
Co-authored-by: Pariente Manuel <pariente.mnl@gmail.com>
Contributor
Author
|
Thank you for your revising, @mpariente! I'm fine for all of your suggestions. |
Collaborator
|
Merged! Thanks to all involved ! |
Contributor
Author
|
@mpariente I'm sorry for your inconvenient. |
Collaborator
|
I let you make a new PR |
Contributor
Author
|
OK, I will follow your suggestion. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank @TE-StefanUhlich, @faroit and @mpariente for lots of efforts!! I would like to do PR regarding X-UMX.
The differences between
official masterandxumx_branchare summarized as follows:[newly added]
･
asteroid/tests/models/xumx_test.py･
asteroid/egs/musdb18/X-UMX･
asteroid/asteroid/models/x_umx.py[modified]
･
asteroid/asteroid/models/__init__.py･
asteroid/asteroid/utils/hub_utils.py