Skip to content

Add library version and name for Hugging Face download stats#524

Merged
mpariente merged 2 commits intoasteroid-team:masterfrom
osanseviero:master
Jul 1, 2021
Merged

Add library version and name for Hugging Face download stats#524
mpariente merged 2 commits intoasteroid-team:masterfrom
osanseviero:master

Conversation

@osanseviero
Copy link
Contributor

This will enable Asteroid-specific download stats.

FYI @julien-c

@mpariente
Copy link
Collaborator

Thanks for the PR, that would be nice indeed!
The minimum version in the requirements (here) is 0.0.2, is that enough?

Could you lint the PR please? I'll merge right after.
Thanks !

@osanseviero
Copy link
Contributor Author

Done :)

Yes, cached_download had the library name/version params since the beginning, so it should work fine with early versions(@LysandreJik please correct me if I'm wrong :) )

@LysandreJik
Copy link

You are correct!

@mpariente
Copy link
Collaborator

Thanks to both of you

@mpariente mpariente merged commit f66d65c into asteroid-team:master Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants