Skip to content

[install] pytorch-optimizer dropped RAdam#568

Merged
mpariente merged 1 commit intoasteroid-team:masterfrom
ben-freist:fix-torch-optimizer-version
Oct 28, 2021
Merged

[install] pytorch-optimizer dropped RAdam#568
mpariente merged 1 commit intoasteroid-team:masterfrom
ben-freist:fix-torch-optimizer-version

Conversation

@ben-freist
Copy link
Contributor

In jettify/pytorch-optimizer#377 the RAdam optimizer was removed from pytorch-optimizer, it's still used in asteroid though. So we restrict the version to be earlier than 0.2.0.

In jettify/pytorch-optimizer#377 the RAdam optimizer was removed from
pytorch-optimizer, it's still used in aseroid though.
@mpariente
Copy link
Collaborator

That looks perfect, but the docs are failing for some reason.
@JorisCos, would you like to have a look at that?

@mpariente
Copy link
Collaborator

Reagardless, I think I'll merge because in the current state, asteroid cannot even be imported.

@mpariente mpariente merged commit d21a188 into asteroid-team:master Oct 28, 2021
@mpariente
Copy link
Collaborator

Thanks!

@ben-freist ben-freist deleted the fix-torch-optimizer-version branch October 29, 2021 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants