MixIT loss function#595
Merged
mpariente merged 4 commits intoasteroid-team:masterfrom Feb 9, 2022
zmolikova:mixit_loss_bug
Merged
MixIT loss function#595mpariente merged 4 commits intoasteroid-team:masterfrom zmolikova:mixit_loss_bug
mpariente merged 4 commits intoasteroid-team:masterfrom
zmolikova:mixit_loss_bug
Conversation
Collaborator
|
Thanks ! Can we add a test case to be sure that the exception is captured? Maybe with a pairwise loss? |
Contributor
Author
|
Yes, I added the test. |
Collaborator
|
Thank you very much, that's perfect ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves the issue #594 and adds a simple dimension check to prevent using wrong loss function with MixIT wrapper.