Fix shape mismatching in SuDORMRF's masknn#618
Merged
mpariente merged 1 commit intoasteroid-team:masterfrom Jun 7, 2022
Merged
Fix shape mismatching in SuDORMRF's masknn#618mpariente merged 1 commit intoasteroid-team:masterfrom
mpariente merged 1 commit intoasteroid-team:masterfrom
Conversation
Contributor
Author
Test Environment.Test Model
Test codeException printDebugging print
Cause of exceptionIn below code, 'depth 3' ([1, 512, 202]) is upsampled to [1, 512, 404] (assigned to resampled_out_k). |
Collaborator
|
Thanks for the PR and the great detail in the explanation of the problem ! The CI failures are not due to your code, so it's merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the length of input audio tensor, sometimes U-ConvBlock's tensor shape becomes odd number.
In this case, shape miss-matching is occurred in process of downsampling and upsampling.
This commit trims additional last data in upsampling sequence.