Upgrade deprecated huggingface_hub.cached_download#645
Merged
mpariente merged 2 commits intoasteroid-team:masterfrom Oct 24, 2022
Merged
Upgrade deprecated huggingface_hub.cached_download#645mpariente merged 2 commits intoasteroid-team:masterfrom
mpariente merged 2 commits intoasteroid-team:masterfrom
Conversation
Collaborator
|
Thank you very much for the PR. Have you tested it ? In which version has the |
Contributor
Author
|
I tried it manually and all the tests for cached_download continue to pass.
I haven't yet checked in which version it was introduced, but it's present
in the version you get from requirements.txt. We can investigate further
though.
|
Collaborator
|
Then it's perfect, thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #644
Removes the warning by following the upgrade instructions