Fix continuous integration#672
Merged
mpariente merged 11 commits intoasteroid-team:masterfrom Jul 6, 2023
Merged
Conversation
…1, replaced by hann
Collaborator
|
This is perfect, thank you ! ✨ It's in the commits, but I rewrite it here for more visibility : |
Collaborator
|
Regarding your questions :
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @mpariente 🐿️
I tried to fix the continuous integration before doing a new release (as mentioned in #664).
It should work 🤞 But I have a couple of questions:
masterintoci_fixbranch. Should I have forked the repo a second time before doing my new commits? Or rebase my development branch as proposed here?scipy.signal.get_window(window="hanning")is not supported in newer version of scipy and is replaced bywindow="hann"(check documentation v0.11.0 vs v1.11.1). I didn't succeed to install a version ofscipywhich works withwindow="hanning"and is compatible with the others libraries installed in the requirements. So instead, I replacedhanningbyhannin the arguments and changed the requirements toscipy>=1.10.1(which works on my computer). I feel like it is not the best solution aswindow="hanning"was working before, should I change this fix?Thanks!