Use explicit credentials cache instead of global static #16768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konstin
had a problem deploying
to
uv-test-registries
GitHub Actions
Failure
konstin
force-pushed
the
konsti/dont-use-a-global-mutable-credential-cache
branch
from
2d19aa5 to
920d5e1
Compare
konstin
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
konstin
force-pushed
the
konsti/dont-use-a-global-mutable-credential-cache
branch
from
920d5e1 to
2bd9262
Compare
konstin
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
konstin
changed the title
konstin
added
the
enhancement
konstin
force-pushed
the
konsti/dont-use-a-global-mutable-credential-cache
branch
from
2bd9262 to
49290de
Compare
konstin
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
zanieb
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16447
Passing this around explicitly uncovers some behaviors where we pass e.g. the credentials store to reading the lockfile. The changes in this PR should preserve the existing behavior for now, they only make the locations we read from more explicit.
Labeling this PR as "Enhancement" instead of "Internal" in case this changes behavior when it shouldn't have.