Skip to content

Reduce reads and file exists checks#639

Merged
delucchi-cmu merged 4 commits intomainfrom
delucchi/iops
Feb 20, 2026
Merged

Reduce reads and file exists checks#639
delucchi-cmu merged 4 commits intomainfrom
delucchi/iops

Conversation

@delucchi-cmu
Copy link
Contributor

Change Description

Related to, but does not close, LSDB astronomy-commons/lsdb#1249

Solution Description

  • Reduces the number of times we check if a file exists before reading it. We still want to occasionally check, in the case that there are legacy file names.
  • Reduces the file_io API surface, as many methods are just a thin wrapper around Path methods.

Code Quality

  • I have read the Contribution Guide and agree to the Code of Conduct
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

@github-actions
Copy link

github-actions bot commented Feb 20, 2026

Before [b6cebe1] After [3564a43] Ratio Benchmark (Parameter)
1.06±0.04ms 1.08±0.03ms 1.02 benchmarks.time_test_cone_filter_multiple_order
267±2ms 269±2ms 1.01 benchmarks.time_small_cone_large_catalog
118±0.4ms 119±1ms 1.01 benchmarks.time_test_alignment_even_sky
5.40±0.4ms 5.39±0.4ms 1 benchmarks.ConeFilterSuite.time_cone_filter_benchmark
268±2ms 269±3ms 1 benchmarks.time_open_large_catalog
44.0±0.3ms 43.8±0.3ms 1 benchmarks.time_open_midsize_catalog
13.2±0.3ms 13.0±0.5ms 0.99 benchmarks.Suite.time_inner_pixel_alignment
395±1ms 393±1ms 0.99 benchmarks.Suite.time_outer_pixel_alignment
42.0±0.8ms 41.6±0.5ms 0.99 benchmarks.Suite.time_pixel_tree_creation

Click here to view all benchmarks.

@codecov
Copy link

codecov bot commented Feb 20, 2026

Codecov Report

❌ Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.56%. Comparing base (b6cebe1) to head (a42edc4).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/hats/io/parquet_metadata.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #639      +/-   ##
==========================================
- Coverage   92.70%   92.56%   -0.15%     
==========================================
  Files          51       51              
  Lines        2702     2675      -27     
==========================================
- Hits         2505     2476      -29     
- Misses        197      199       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@smcguire-cmu smcguire-cmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@delucchi-cmu delucchi-cmu merged commit 77fe8fd into main Feb 20, 2026
11 of 12 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/iops branch February 20, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants