Skip to content

Feat: Implement Principle of least privilege#82

Merged
dipanshu-astuto merged 4 commits intomasterfrom
feat/add-least-privilege
Nov 7, 2025
Merged

Feat: Implement Principle of least privilege#82
dipanshu-astuto merged 4 commits intomasterfrom
feat/add-least-privilege

Conversation

@dipanshu-astuto
Copy link
Contributor

No description provided.

…values.yaml and related templates for shared permissions
…ith bootstrap RBAC configuration and add corresponding templates for cluster role and binding. This ensures proper resource management during installation and cleanup processes.
… configuration files, including globalvalues.yaml, install.sh, and Chart.yaml. Adjust image tags and release version accordingly in values.yaml and version.md.
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @dipanshu-astuto, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the security posture of the Onelens Deployer by implementing the Principle of Least Privilege within its Kubernetes RBAC configurations. The changes introduce a clear separation of permissions for initial deployments versus ongoing operations, ensuring that each component operates with the minimum necessary access rights. This refactoring not only improves security but also clarifies the responsibilities of different service accounts. Additionally, the update includes a general version bump across all related components and a regional API endpoint adjustment.

Highlights

  • Version Updates: All relevant Helm charts and deployment scripts have been updated to version 1.9.0.
  • Principle of Least Privilege Implementation: The Kubernetes Role-Based Access Control (RBAC) configuration has been refactored to adhere to the Principle of Least Privilege, ensuring components only have necessary permissions.
  • Separated RBAC for Bootstrap and Ongoing Operations: Distinct RBAC roles and bindings are now defined for the initial installation (bootstrap) phase and for ongoing operational tasks, with temporary bootstrap roles being cleaned up post-installation.
  • Granular Cluster-Scoped Permissions: Cluster-scoped permissions are now highly restricted, utilizing resourceNames to limit access to specific resources where applicable, alongside read-only access for monitoring purposes.
  • API Endpoint Change: The default API endpoint has been updated from api-gp.onelens.cloud to api-in.onelens.cloud.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request does an excellent job of implementing the principle of least privilege for the onelens deployer. The separation of temporary bootstrap permissions from long-running operational permissions is a great security improvement. Consolidating the RBAC rules for the installation job and the updater cronjob also simplifies the configuration. My review includes a few suggestions to further enhance security by tightening a namespace-scoped role, improve maintainability by removing deprecated API groups, and fix a minor typo in a filename.

@dipanshu-astuto dipanshu-astuto merged commit 0e0e63e into master Nov 7, 2025
@dipanshu-astuto dipanshu-astuto deleted the feat/add-least-privilege branch November 7, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants