Draft
Conversation
kakra
force-pushed
the
queue/for-0.11
branch
16 times, most recently
from
1fac037 to
cdec5a9
Compare
kakra
force-pushed
the
queue/for-0.11
branch
3 times, most recently
from
07f0f71 to
5c974f5
Compare
kakra
force-pushed
the
queue/for-0.11
branch
6 times, most recently
from
5f1857b to
e8b1bbb
Compare
We may see problems with some controllers which do not properly ACK the rumble packets or ACK them too early, resulting in a firmware crash or losing rumble support until reboot. Observed logs: [ 263.617389] xpadneo 0005:045E:0B13.0001: throttled rumble reprogramming [ 627.167815] xpadneo 0005:045E:0B13.0001: failed to send rumble report: -5 This means the device ended up showing input/output error 363.5s after detecting the first rumble throttling (game sends rumble faster than the controller can accept it). Affected controllers are XBE2 and XBXS, so it seems to be a general issue with all genuine BLE issues. But affected controllers also have in common that they show a firmware version higher than 5.20 while unaffected devices so far are on displayed version 5.15 (even if the firmware has been updated to 5.23 using the Xbox Accessories App and the latter confirms the update). We might be dealing with a new quirk of a new hardware revision. Forcefully disabling HOGP will not rely on ACK behavior but fall back to legacy behavior, forcing a delay of 20ms after sending each rumble packet - which has been mostly safe for all modern BLE controllers during the last years. See-also: atar-axis#607 Signed-off-by: Kai Krakow <kai@kaishome.de>
Todo: - [ ] Dump of descriptors should be in the docs/descriptors - [ ] Add descriptor fixups lingering in the PR commits New known checksums: - Xbox One Elite Series 2 legacy firmware - Xbox One S 1708 (fw 0x0903 with truncated rumble descriptor) Link: atar-axis#603 Signed-off-by: Kai Krakow <kai@kaishome.de>
- Add logs to measure timing and show attempted effect uploads - Not useful in production - Will be dropped before merging into master Signed-off-by: Kai Krakow <kai@kaishome.de>
Nobara Linux may use a heavily modified custom version of xpadneo which may see different types of bugs we cannot see. This will be handled by the maintainer of the Nobara Linux kernel, and fixes will be ported to xpadneo. This is a just hint that we may not be able to handle the bug report directly in xpadneo. Signed-off-by: Kai Krakow <kai@kaishome.de>
We, the maintainers of xpadneo, understand AI as a helping tool. But following a similar strategy as the kernel, we explicitly require that a human takes full responsibility for using such tools. Thus we require that each commit has been verified, reviewed and tested by a human being. This responsibility has to be confirmed by including no Co-authored-by for an AI agent and adding a Signed-off-by of your human identity. Signed-off-by: Kai Krakow <kai@kaishome.de>
41 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is purely for CI testing and reviews before commits are merged into the master branch, preparing the future v0.11 version.
Do not base your work on this, it will be rebased or force-pushed often.