Add support for changes to Ruby C API #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The current binary release of QLPrettyPatch doesn't work on new versions of OS X (eg, 10.11) because of the newer libruby. I guess the best solution would be to dynamically load libruby, but that's a fix for another day...
Unfortunately a quick recompile on 10.11 didn't work due to changes in the Ruby C API. Attached is a small patch that adds support for the new C API. It's a very quick hack and I've not double checked exactly when ruby_exec() was dropped, but the fix works fine on 10.11. There do appear to be some issues with newer versions of the C API not initialising correctly after a cleanup, so I've disabled the cleanup (that seemed to be the only workaround I could find at short notice).
Hope this is useful.
Cheers, MJ