Crash in atom/atom macOS CI

[smashwilson]

There's a crash in atom/atom's macOS CI that's preventing us from pushing any releases upstream.

@DeeDeeG has helpfully done a ton of investigation here already; details in the conversation on atom/atom#21782. The PR that introduced the failure seems to be #2587, which unfortunately is a pretty important one.

[DeeDeeG]

@smashwilson FWIW I am seeing this CI issue on macOS, and not on Windows.

Edit: To be fair, that is the only OS that runs the package tests at atom/atom for the moment, so I suppose there's no evidence it's a macOS only bug. Running the package tests on the other platforms would tell.

[smashwilson]

Oh! Got it.

[DeeDeeG]

So, based on recent discussions in some other issues and PRs, it would seem something between 0.36.3 and 0.36.6 (probably #2587) broke about five or seven of the integration: file-patching tests for multiple scenarios.

Affected scenarios are at least:

• Atom's (Azure Pipeleines-based) CI (PR: GitHub 0.36.5 to dev atom#21782)
• This repo's CI if trying to use action-setup-atom (PR: use action-setup-atom #2459).

[DeeDeeG]

Pasting this here as well:

The underlying problem was discovered during discussion of #2459.

Some tests in github as of 0.36.5 assume user.name and user.email are configured for the git on the system PATH, and if those configs aren't set, the tests never complete.