Open
Conversation
pk910
force-pushed
the
pk910/dynssz-codegen
branch
from
e43b1d8 to
5a3d258
Compare
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the code generator for ssz code to dynamic-ssz.
The code generated by dynamic-ssz has equal performance characteristics as the code generated by fastssz.
Biggest benefit of switching to the dynssz codegen: no more pre- and post work to get the damn ssz code generated. The code generator just works out of the box 🎉. It uses types properly and does not require manual edits, which is a huge pain with the existing fastssz code generator.
supersedes #260, #242
fixes #259