Dissallow deletion if the '--limit' flag is present#1436
Merged
ellie merged 1 commit intoatuinsh:mainfrom Dec 11, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ellie
approved these changes
Dec 11, 2023
This was referenced Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for writing and supporting atuin!
I ran into a bug where if you combine the --limit and --deletion flags it would delete all of the matching entries instead of some limited number. For example:
Unfortunately I had searched for
"*"so all my history is gone, luckily on a relatively new computer so not a critical loss.This is on nixos with atuin version 17.0.1, but the relevant code hasn't meaningfully changed since.
Looking at the code it wasn't obvious what combining "--limit" and "--delete" would even mean, so I put together this change to disallow them from being combined and a comment explaining why.
I tested that the combination of flags does print the message saying they're not compatible and exits.