(fix): remove no else raise and no else return rules from .pylintrc#3525
Closed
pushpitkamboj wants to merge 4 commits intoaugurlabs:mainfrom
Closed
(fix): remove no else raise and no else return rules from .pylintrc#3525pushpitkamboj wants to merge 4 commits intoaugurlabs:mainfrom
pushpitkamboj wants to merge 4 commits intoaugurlabs:mainfrom
Conversation
Signed-off-by: PredictiveManish <manish.tiwari.09@zohomail.in>
Signed-off-by: PredictiveManish <manish.tiwari.09@zohomail.in>
Signed-off-by: pushpit kamboj <pushpitkamboj@gmail.com>
pushpitkamboj
force-pushed
the
fix_linter
branch
from
88feafb to
eccef7f
Compare
MoralCode
changed the title
MoralCode
requested changes
Jan 8, 2026
Collaborator
MoralCode
left a comment
MoralCode
left a comment
There was a problem hiding this comment.
Thanks for this PR and for including documentation links in the PR so i can verify the (annoying) copilot comments
Comment on lines
49
to
52
Collaborator
There was a problem hiding this comment.
This change is not related - can you update your PR to only include the changes to the pylintrc?
MoralCode
added
the
redundant
Signed-off-by: pushpit kamboj <pushpitkamboj@gmail.com>
Contributor
Author
|
sorry it was my mistake, thought to raise a new clean PR which will be better to have clean history. |
Contributor
|
Hey @pushpitkamboj, for future reference, you did not need to open a new PR. It is perfectly fine to address feedback in the same PR. This keeps the conversation thread intact. |
Collaborator
|
Closing as superseded by #3533 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #3521
Removed rules R1720 and R1705 from
.pylintrc, disabling suggestions to removeraiseorreturnblocks.