fix(openai): validate encoder input before embeddings call#657
Open
pandego wants to merge 1 commit intoaurelio-labs:mainfrom
Open
fix(openai): validate encoder input before embeddings call#657pandego wants to merge 1 commit intoaurelio-labs:mainfrom
pandego wants to merge 1 commit intoaurelio-labs:mainfrom
Conversation
Member
|
good call - I'll have workflows run and merge when complete |
Contributor
Author
|
Thanks! I checked the failing CI jobs. The current failures are Pinecone router tests in |
Member
|
yeah they're unrelated - I need to double check our CI pipeline envs @pandego |
40161c4 to
be4578c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OpenAIEncoderbefore calling the embeddings APIValueErrormessages for:Why
Issue #530 reports OpenAI returning
400 '$.input' is invalid, which is difficult to diagnose from user code. This change catches common invalid input shapes earlier and surfaces clearer, actionable errors before the API call.Validation
uv run pytest tests/unit/encoders/test_openai.py16 passedCloses #530