cmd/ausoceantv: if there is no refresh token, prompt consent#523
Merged
trekhopton merged 3 commits intomainfrom Mar 28, 2025
Merged
cmd/ausoceantv: if there is no refresh token, prompt consent#523trekhopton merged 3 commits intomainfrom
trekhopton merged 3 commits intomainfrom
Conversation
There's no way of getting another refresh token if it's gone for some reason (user clears cookies), so we need to check and prompt for consent if it's missing to get another refresh token. Unless we decide we want to store the refresh tokens in our DB.
ao-david
approved these changes
Mar 26, 2025
This was done to prevent silent errors or unexpected behaviour from nil sessions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no way of getting another refresh token if it's gone for some reason (user clears cookies), so we need to check and prompt for consent if it's missing to get another refresh token. Unless we decide we want to store the refresh tokens in our DB.