Merged
Conversation
This change adds a button which will auto-generate the default actions for a controller and a camera, which are typically the only variables used. This reduces the chance of an error, whilst also decreasing the time to setup a broadcast.
This was done to clean up code style.
This change makes sure we only create the broadcastCheck cron if it doesn't exist already. This ensures that if we've modified the broadcast check cron to hit the testing endpoint we don't overwrite that whenever we save the broadcast config.
This was done to improve readability.
Other changes include: - delete trailing comma - have a select option for deselecting camera and controller even if one is already selected - generate actions for just camera or just controller or both These were done to be a better user experience
camera/rv modes start with a capital and I'm not sure lowercase get handled well.
The camera and controller text bottoms were being cut off which just looked bad.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.